Release: Update nydus snapshotter version #364
Conversation
This is updated to match the nydus snapshotter version (v0.13.11) from the v3.4.0 kata release Signed-off-by: Chris Porter <[email protected]>
portersrc
force-pushed
the
pre-release-fixes-v0.9.0
branch
from
053c00d
to
6be3af2
Compare
| rm nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-${ARCH}.tgz && \ | ||
| curl -fOL --progress-bar ${NYDUS_SNAPSHOTTER_REPO}/releases/download/${NYDUS_SNAPSHOTTER_VERSION}/nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-linux-${ARCH}.tar.gz && \ | ||
| tar xvzpf nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-linux-${ARCH}.tar.gz -C / && \ | ||
| rm nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-linux-${ARCH}.tar.gz && \ | ||
| mv /nydus-snapshotter/* ${NODE_DESTINATION}/bin/ && \ |
There was a problem hiding this comment.
The v0.13.11 doesn't use the nydus-snapshotter prefix inside the tarball so you need to remove the lines 75,76 (mv and rm /nydus-snapshotter)
There was a problem hiding this comment.
This is a good catch. I think I made a slightly different but appropriate change and see enclave-cc test passing now
There was a problem hiding this comment.
thanks @portersrc, this changes the repo to the official one, which is in sync with kata-containers. The only little issue is that that version doesn't use the prefix inside the tarball but is directly uncompressed as it should. Once you remove the 2 extra lines it should be good to go.
portersrc
force-pushed
the
pre-release-fixes-v0.9.0
branch
from
831dca3
to
2811e20
Compare
| mkdir /nydus-snapshotter && \ | ||
| tar xvzpf nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-linux-${ARCH}.tar.gz -C /nydus-snapshotter && \ | ||
| rm nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-linux-${ARCH}.tar.gz && \ | ||
| mv /nydus-snapshotter/bin/* ${NODE_DESTINATION}/bin/ && \ |
There was a problem hiding this comment.
Well this ensures only bin/* files will be deployed (no matter what nydus packs) but do you think it's necessary to create, move and remove the files? I think simple deployment directly to / would be more elegant (with some pros - like when nydus adds extra files, and cons - when nydus adds extra files we don't want to deploy)
There was a problem hiding this comment.
Note it's not a strict requirement, just my preference. So feel free to say you really really want it this way and I will get along with this complicated construct...
There was a problem hiding this comment.
Btw it must be extracted to tar xvzpf nydus-snapshotter-${NYDUS_SNAPSHOTTER_VERSION}-${ARCH}.tgz -C ${NODE_DESTINATION}/bin/ && \ then everything works well...
There was a problem hiding this comment.
👍 thanks @ldoktor. I incorporated this suggested now, and it seems to still be passing (just awaiting one last runner again).
A few tweaks to pull the correct nydus-snapshotter tarball are needed: the remote repo, the tarball suffix, the "linux" string within the tarball name, no need for amd64 vs. x86_64 checking, and handling of extracted tarball slightly tweaked Signed-off-by: Chris Porter <[email protected]>
portersrc
force-pushed
the
pre-release-fixes-v0.9.0
branch
from
2811e20
to
1c93e89
Compare
|
Hi @portersrc ! Can I get this merged or are you waiting on some other PR? |
|
Thanks, guys. Yes this was OK to merge. We can perform the rest of v0.9.0 steps now, I believe. |
This is updated to match the nydus snapshotter version (v0.13.11) from the v3.4.0 kata release.
This is needed for v0.9.0 release process.