attestation: verifier: tdx: Allow equals in kernel param values #227
Conversation
| @@ -275,4 +272,229 @@ mod tests { | |||
|
|
|||
| assert_json_eq!(expected, claims); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_parse_kernel_parameters() { | |||
There was a problem hiding this comment.
I like the detailed test cases very much, thanks for this! Could you use https://crates.io/crates/rstest crate to make it more rusty?
There was a problem hiding this comment.
@Xynnn007 - Branch updated.
Added a unit test for `parse_kernel_parameters()`. Signed-off-by: James O. D. Hunt <[email protected]>
Allow kernel parameter values to contain equal signs, for example: ``` module_foo=bar=baz,wibble_setting=2 ``` Fixes: confidential-containers#226. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
tdx-verifier-kernel-params-with-equals
branch
from
84e802f to
130a536
Compare
|
The fixes link looks wrong |
True. Probably because this PR was originally opened against the AS repo. We don't actually require the fixes thing in this repo. |
I mentioned it because I'm not able to re-open to continue the work. Are you able to do that? |
Ah, yes. I can reopen. Sorry about that. |
Allow kernel parameter values to contain equal signs, for example:
Fixes: #163.
Signed-off-by: James O. D. Hunt [email protected]