Cca: Get the evidence from EAR (EAT Attesation Result) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cc other reviewers for review, cc @Xynnn007 @fitzthum @jialez0 this is replacement of the confidential-containers/attestation-service#159 |
chendave
force-pushed
the
evidence
branch
2 times, most recently
from
7e78c87 to
3ae3097
Compare
Xynnn007
reviewed
Nov 28, 2023
| @@ -130,156 +154,104 @@ impl Verifier for CCA { | |||
| warn!("CCA currently does not support parse `cca_realm_personalization_value`. Init data hash check skipped."); | |||
There was a problem hiding this comment.
Can we support to verify this item after this PR?
There was a problem hiding this comment.
yes, I will push one additional commit to fix it.
chendave
force-pushed
the
evidence
branch
6 times, most recently
from
54dc0ab to
65a0379
Compare
CCA validation by the Verasion has some overlapping with the RVPS, the similar validation has been done by the Verasion already. So the validation of evidence in CoCo is not needed in theory. The parse of the CCA token here is to align with other verifier, e.g. TDX, and to support RVPS if that is the case of future planning. NOTE that each of the value we get from EAR is base64 encoded hex value. So, the reference value that are registered for RVPS are expected to be base64 encoded hex value as well. [1] https://datatracker.ietf.org/doc/draft-ietf-rats-ar4si/ Signed-off-by: Dave Chen <[email protected]>
|
Can we merge this? or anything else I can do? |
Now, the init data will be checked against the value from CCA token. Signed-off-by: Dave Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCA validation by the Verasion has some overlapping with the RVPS, the similar validation has been done by the Verasion already. So the validation of evidence in CoCo is not needed in theory.
The parse of the CCA token here is to align with other verifier, e.g. TDX, and to support RVPS if that is the case of future planning.
NOTE that each of the value we get from EAR is base64 encoded hex value. So, the reference value that are registered for RVPS are expected to be base64 encoded hex value as well.
[1] https://datatracker.ietf.org/doc/draft-ietf-rats-ar4si/