Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifier: Refactor errors in cca module #326
base: main
Are you sure you want to change the base?
Verifier: Refactor errors in cca module #326
Changes from all commits
a395ea7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some extra information to this kind of error? I mean if this error is raised, the user will only see
Serde Json Error
and he will not know what is serdedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding error types with source as serde::json error and whole context for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am worried about this kind of error. Other types have determined semantics while this not. Could you try to classify the source of this error as one of the above and use
map_err
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that severval
.into()
are used in this function to convertResult<_, CCAError>
toResult<_, anyhow::Error>
.One way to avoid this is to have an inner non-pub function
cca_evaluate() -> Result<_, CCAError>
to be wrapped by thisevaluate()
. Incca_evaluate()
can delete all the.into()
s. And inevaluate()
just callcca_evaluate()
to finish the error conversion.Another way is to add another overall error type
VerifierError
underverifier
. One enum is namedCCA
. And change the signature ofevaluate(..)->anyhow::Result<TeeEvidenceParsedClaim>
toevaluate(..)->Result<TeeEvidenceParsedClaim, VerifierError>
. In this function differentCCAError
s will finally be mapped intoVerifierError::CCA
.It's up to you : )