Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: fix binary build on self-hosted runners #438

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Jul 4, 2024

Split the build of the binaries out to a gh-hosted runner, only the tests need to run on TEE hw.

This fixes missing build tools on self-hosted runners and improves the caching.

Since the CI will use the workflow files on main, the test results won't reflect the changes, a test run on a fork can be seen here

n/m that doesn't apply to the sample attester

@mkulke mkulke requested a review from sameo as a code owner July 4, 2024 10:41
@mkulke mkulke requested review from fitzthum and Xynnn007 July 4, 2024 10:41
@mkulke mkulke mentioned this pull request Jul 4, 2024
split the build of the binaries out to a gh-hosted runner, only the test
need to run on TEE hw.

Signed-off-by: Magnus Kulke <[email protected]>
@mkulke mkulke force-pushed the mkulke/fix-kbs-e2e-test-binaries-build branch from c5a1f51 to 0d47ada Compare July 4, 2024 10:44
@mkulke mkulke merged commit a4d89fc into confidential-containers:main Jul 5, 2024
14 checks passed
@mkulke mkulke deleted the mkulke/fix-kbs-e2e-test-binaries-build branch July 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants