Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump az-tdx-vtpm from 0.5.3 to 0.6.0 #463

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 13, 2024

Bumps az-tdx-vtpm from 0.5.3 to 0.6.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [az-tdx-vtpm](https://github.com/kinvolk/azure-cvm-tooling) from 0.5.3 to 0.6.0.
- [Commits](kinvolk/azure-cvm-tooling@v0.5.3...v0.6.0)

---
updated-dependencies:
- dependency-name: az-tdx-vtpm
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from sameo as a code owner August 13, 2024 01:37
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Aug 13, 2024
@Xynnn007
Copy link
Member

cc @mkulke

@Xynnn007
Copy link
Member

we might need to update this crate manually

@mkulke
Copy link
Contributor

mkulke commented Aug 13, 2024

@Xynnn007 thx, any idea why dependabot would attempt to bump minor versions (pre 1.0 this should be breaking changes)? this won't apply automatically, and also needs adjustments on guest-components. maybe ignore?

@mythi
Copy link
Contributor

mythi commented Aug 13, 2024

we haven't configured any exclude rules for dependabot so it just triggers these PRs upon new versions. We can quite easily to make it ignore this dependency completely by "dependabot ignore this dependency"

@mkulke
Copy link
Contributor

mkulke commented Aug 13, 2024

hmm, the version has been out for a while. but maybe dependabot has just been activated. in this case dependabot attempts to update a crate with a breaking change (it's verified with cargo semver), I suppose this can create a lot of work, do we want this?

@mythi
Copy link
Contributor

mythi commented Aug 13, 2024

dependabot has been activated for a long time but it's configured to keep one open PR at a time. With (dependabot) PRs now getting merged faster, we got to see it bump az-tdx-vtpm this time. I don't know how it decides the next candidate but like I said, we could just dependabot ignore this dependency and move to the next one.

@mkulke
Copy link
Contributor

mkulke commented Aug 13, 2024

dependabot has been activated for a long time but it's configured to keep one open PR at a time. With (dependabot) PRs now getting merged faster, we got to see it bump az-tdx-vtpm this time. I don't know how it decides the next candidate but like I said, we could just dependabot ignore this dependency and move to the next one.

ah, thanks for clariying, then I'll just close this.

@mkulke mkulke closed this Aug 13, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 13, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/az-tdx-vtpm-0.6.0 branch August 13, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants