Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ita: add support for Azure attestation using dedicated API #494

Merged
merged 1 commit into from
Sep 11, 2024
Merged

ita: add support for Azure attestation using dedicated API #494

merged 1 commit into from
Sep 11, 2024

Conversation

pawelpros
Copy link
Contributor

Add support for azure tdxvm API and update attestation request body accordingly to chosen tee

@pawelpros pawelpros changed the title ita: add support for Amber attestation using separate dedicated API ita: add support for Azure attestation using separate dedicated API Sep 9, 2024
@pawelpros pawelpros changed the title ita: add support for Azure attestation using separate dedicated API ita: add support for Azure attestation using dedicated API Sep 9, 2024
mythi
mythi reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Amber/Azure/ :-)

kbs/src/attestation/intel_trust_authority/mod.rs Show resolved Hide resolved
kbs/src/attestation/intel_trust_authority/mod.rs Outdated Show resolved Hide resolved
kbs/src/attestation/intel_trust_authority/mod.rs Outdated Show resolved Hide resolved
@pawelpros pawelpros marked this pull request as ready for review September 10, 2024 06:09
@pawelpros pawelpros requested a review from a team as a code owner September 10, 2024 06:09
mythi
mythi approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor suggestions

kbs/src/attestation/intel_trust_authority/mod.rs Outdated Show resolved Hide resolved
kbs/src/attestation/intel_trust_authority/mod.rs Show resolved Hide resolved
@mythi
Copy link
Contributor

mythi commented Sep 10, 2024

this needs one minor update after #491 lands

@mythi mythi mentioned this pull request Sep 11, 2024
Merged
@fidencio fidencio added the test_e2e Authorize TEE e2e test run label Sep 11, 2024
@pawelpros
ita: add support for Azure attestation using dedicated API
c19f8fe 
Add support for azure tdxvm API and update attestation request body accordingly to chosen tee

Signed-off-by: Pawel Proskurnicki <[email protected]>
jodh-intel
jodh-intel approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pawelpros.

lgtm

fidencio
fidencio approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, dzięki @pawelpros!

@fidencio fidencio merged commit d075eef into confidential-containers:main Sep 11, 2024
16 checks passed
@pawelpros pawelpros deleted the ita branch September 11, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fidencio fidencio fidencio approved these changes

@mythi mythi mythi approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Assignees
No one assigned
Labels
test_e2e Authorize TEE e2e test run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawelpros @mythi @fidencio @jodh-intel