Release: Improve release scripting #513
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `docker manifest create` command for creating the latest tag had a typo which needed amending. Also, the way the loops and associative arrays are written, this `docker manifest create` command would have run more than once for the same `latest` package. This was probably not intended, because ghcr will only accept 1 latest tag for the same package anyway. So, this change also moves the `docker manifest create` command outside of the loop to avoid this ambiguity and chooses the release package name without any prefix to be the latest version (e.g. opting for key-broker-service:v0.10.0 for the latest tag instead of key-broker-service:built-in-as-v0.10.0). Signed-off-by: Chris Porter <[email protected]>
The release-helper script did two things: bump the version in the kustomization file, and update the ghcr packages with release tags. The latter step should be triggered by a github action on release and should not require a user to manually run it. Thus, it makes sense to separate this into its own script. Signed-off-by: Chris Porter <[email protected]>
Rather than manuallyu execute a script for tagging ghcr packages at release time, this can be more reliably automated in a github action that's triggered on release. This new github action simply calls the previous release-helper script support that is in place. Signed-off-by: Chris Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release-helper script for trustee needed some attention, which this PR tries to address:
docker manifest createwas used for thelatesttagThese tasks came about from here.
Comments for reviewers:
release-helper-kustfile.shat all now? It's just asedwith a lot of noise to create a PR. If we expect this to grow then it may be worth keeping.