Remove the parameters of onconfigchange

configcat · Jan 30, 2020 · cd3b5cc · cd3b5cc
1 parent 23cb94b
commit cd3b5cc
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/ConfigCat.podspec b/ConfigCat.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |spec|
 
   spec.name          = "ConfigCat"
-  spec.version       = "3.0.0"
+  spec.version       = "3.1.0"
   spec.summary       = "ConfigCat Swift SDK"
   spec.swift_version = "4.2"
 

diff --git a/Sources/AutoPollingPolicy.swift b/Sources/AutoPollingPolicy.swift
@@ -49,7 +49,7 @@ final class AutoPollingPolicy : RefreshPolicy {
                     let cached = self.cache.get()
                     if response.isFetched() && response.body != cached {
                         self.cache.set(value: response.body)
-                        self.onConfigChanged?(response.body, AutoPollingPolicy.parser)
+                        self.onConfigChanged?()
                     }
 
                     if !self.initialized.getAndSet(new: true) {

diff --git a/Sources/ConfigCatClient.swift b/Sources/ConfigCatClient.swift
@@ -2,7 +2,7 @@ import Foundation
 import os.log
 
 extension ConfigCatClient {
-    public typealias ConfigChangedHandler = (String, ConfigParser) -> ()
+    public typealias ConfigChangedHandler = () -> ()
 }
 
 /// A client for handling configurations provided by ConfigCat.

diff --git a/Tests/AutoPollingTests.swift b/Tests/AutoPollingTests.swift
@@ -56,21 +56,20 @@ class AutoPollingTests: XCTestCase {
         mockSession.enqueueResponse(response: Response(body: "test", statusCode: 200))
         mockSession.enqueueResponse(response: Response(body: "test2", statusCode: 200))
 
-        var newConfig = ""
+        var called = false
 
-        let mode = PollingModes.autoPoll(autoPollIntervalInSeconds: 2, onConfigChanged: { (config, parser) in
-            newConfig = config
+        let mode = PollingModes.autoPoll(autoPollIntervalInSeconds: 2, onConfigChanged: { () in
+            called = true
         })
         let fetcher = ConfigFetcher(session: mockSession, apiKey: "", mode: mode)
         let policy = mode.accept(visitor: RefreshPolicyFactory(fetcher: fetcher, cache: InMemoryConfigCache()))
 
         sleep(1)
 
-        XCTAssertEqual("test", newConfig)
+        XCTAssertTrue(called)
 
         sleep(3)
 
-        XCTAssertEqual("test2", newConfig)
         XCTAssertEqual("test2", try policy.getConfiguration().get())
     }
 }