Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test suite #89

Open
1 of 2 tasks
willclarktech opened this issue Mar 2, 2021 · 2 comments
Open
1 of 2 tasks

Improve test suite #89

willclarktech opened this issue Mar 2, 2021 · 2 comments
Labels
Library Functionality in the core library

Comments

@willclarktech
Copy link
Contributor

willclarktech commented Mar 2, 2021

This issue is for gathering potential improvements for the test suite.

  • Run tests in parallel where possible. (ava is very good for this.)
  • Remove test suite from testutils.spec.ts
@willclarktech willclarktech added the Library Functionality in the core library label Mar 2, 2021
@ethanfrey
Copy link
Contributor

Move test suite out of testutils.spec.ts

I would simply remove it. These helpers are stable and now covered indirectly from everything else. It was there to bootstrap

@ethanfrey
Copy link
Contributor

Run tests in parallel where possible.

Yup, Most tests that don't do things like "queryAllClients()" should be runable in parallel. We can create 2 different connections with different ids at the same time.

It will also be a good test of the relayer in more difficult, real world situations.

What will likely break:

  • Funding wallets (We submit multiple bank.send tx from the same account. It cannot sign more that one tx per block. We just need to make this controlled by a Mutex or something)
  • Tests that use allXyz() queries - state changes outside of their control

I assume all tests make their own clients, so all connection/channel/packet tests are sandboxed. We could later test two relayers running in parallel on the same connection to ensure it is solid (different issue)

This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Library Functionality in the core library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants