Relayer Loop #99
Merged
Relayer Loop #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
force-pushed
the
12-relayer-loop
branch
from
85e06e3
to
787a14a
Compare
ethanfrey
force-pushed
the
12-relayer-loop
branch
from
787a14a
to
1a137a3
Compare
| }; | ||
|
|
||
| run(options, logger); | ||
| await run(options, logger); |
There was a problem hiding this comment.
no need for await here but it doesn't hurt
There was a problem hiding this comment.
I guess not, but if I neither await nor return the Promise, then if the caller tries await, it will not wait for the final promise with the heart of the work.
I guess we don't do it that way here, but it is a habit after a few gotchas with unawaited promises
| wasmd, | ||
| } from './testutils.spec'; | ||
| } from './testutils'; |
There was a problem hiding this comment.
@ethanfrey This filename had a .spec in it to group it with test files, eg so that it's filtered out of the files published to npm.
There was a problem hiding this comment.
When I removed the unit tests there and left it as spec, ava complained (errored).
Maybe just add this file to the npmignore file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of #12
Part 1 of #89
--onceflag)Follow up PR: