Move error logging into debug if block #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tinc#184) Aligns versions with AK. See also: apache/kafka#8893 Jetty is currently upgraded to a version higher than what Jersey depends on, because the renaming of Response#closeOutput to Response#completeOutput has been reversed in recent versions.
confluentinc/kafka@7be8bd8#diff-10d99f28c40b6cd9640f95b1c763a7b2b4daaa0209249e1a724698f28a90df9bL118-L126 Removed the function definition of createKeyStore that tests in this repo were using. This PR fixes the compilation errors by conforming to the remaining definition of createKeyStore that required two Password args.
An exception should only be logged, if the debug flag is set to true. JavaDoc also states: > Abstract exception mapper that checks the debug flag and generates an error message including the stack trace if it is enabled.
|
It looks like @AdiWehrli hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved error logging into the if block, because Confluent schema-registry produces excessive number of log messages, if it wants to access a schema for a topic key/value which is not defined to have a schema, which should be ignored.
Example (real topic name replaced by a placeholder):
2021-02-04T05:51:16.226 level=ERROR logger=io.confluent.rest.exceptions.DebuggableExceptionMapper thread="qtp1105628551-27" msg="Request Failed with exception " io.confluent.rest.exceptions.RestNotFoundException: Subject '{topicName}-key' not found. at io.confluent.kafka.schemaregistry.rest.exceptions.Errors.subjectNotFoundException(Errors.java:69) at io.confluent.kafka.schemaregistry.storage.KafkaSchemaRegistry.validateAndGetSchema(KafkaSchemaRegistry.java:913) at io.confluent.kafka.schemaregistry.rest.resources.SubjectVersionsResource.getSchemaByVersion(SubjectVersionsResource.java:116)Resolves #221