Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cors to allow schema-registry-ui to connect #1230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@ghost
Copy link

ghost commented Oct 31, 2019

It looks like @ceastman-ibm hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@ceastman-ibm
Copy link
Author

clabot:check

@ceastman-ibm
Copy link
Author

[clabot:check]

@ghost
Copy link

ghost commented Oct 31, 2019

@confluentinc It looks like @ceastman-ibm just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@ceastman-ibm
Copy link
Author

@rayokota Does this look good to you?

@OneCricketeer
Copy link
Contributor

I feel like the current defaults are fine, assuming requests are from the same domain. These options are left up to be configured by the end user, and enabling all domains to access all methods is probably too broad.

These lines could be listed, but commented out to mention why they'd be used (without specifically saying a 3rd party tool).

Connect REST API also has these options, by the way, but these aren't listed there for having the connect UI work

@cla-assistant
Copy link

cla-assistant bot commented Sep 25, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants