Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding metric for when schemas are hard deleted. These metrics do not overlap with soft-deleted metrics.
It should be mentioned that the original ticket was to add soft-delete metric, but in fact the missing metric is hard deletes. Note that soft delete count >= hard delete count, since the schema must be soft deleted first.
Testing
Added test cases, as well as manually running requests.
FAQ:
What happens when a soft deleted schema gets restored then deleted again?
Soft deleted schemas pertaining to a subject can be retrieved with the
deleted=true
flag, which allows you to find the deleted schema and recreate it using the same definition. However, this creates a new version for the subject, and does not map to the old version.What about the workaround to restore hard-deleted schemas?
It is difficult to tell when a hard-deleted schema is restored, since it is recreated using the same definition then manually mapped to a schema id. These are separate operations that cannot definitively be mapped to restoring a hard-deleted schema.