DGS-11414: add pagination for get all subjects #3455
+96
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
pagination/subjects
branch
from
0c4a776 to
29b3bf4
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Analysis Details0 Issues
Coverage and Duplications
Project ID: schema-registry |
djibodu
changed the title
rayokota
reviewed
Dec 10, 2024
Comment on lines
608
to
618
| public int normalizeSchemaLimit(int suppliedLimit) { | ||
| int limit = schemaSearchDefaultLimit; | ||
| if (suppliedLimit > 0 && suppliedLimit <= schemaSearchMaxLimit) { | ||
| limit = suppliedLimit; | ||
| } | ||
| return limit; | ||
| } | ||
|
|
||
| public int normalizeSubjectLimit(int suppliedLimit) { | ||
| int limit = subjectSearchDefaultLimit; | ||
| if (suppliedLimit > 0 && suppliedLimit <= subjectSearchMaxLimit) { |
There was a problem hiding this comment.
Let's combine these into one method that takes a default
public int normalizeLimit(int suppliedLimit, int defaultLimit)
| limit = schemaRegistry.normalizeSubjectLimit(limit); | ||
|
|
||
| stream = stream.skip(offset).limit(limit); | ||
| return stream.collect(Collectors.toCollection(LinkedHashSet::new)); // preserve order |
There was a problem hiding this comment.
nit: can be
return subjects.stream() // add newline
.skip(offset)
.limit(offset)
.collect(...);
There was a problem hiding this comment.
Also, let's change the schemas pagination to use the same logic
airlock-confluentinc
bot
force-pushed
the
pagination/subjects
branch
from
29b3bf4 to
d76b263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding pagination for getAllSubjects. Default and max limit both set to 20,000
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups