Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overwriting argLine execution variable #3500

Open
wants to merge 1 commit into
base: 7.3.x
Choose a base branch
from

Conversation

GunalKupta
Copy link
Contributor

What

JaCoCo coverage reporting does not work when the surefire and failsafe plugins are enabled because they overwrite the argLine variable used by JaCoCo. The solution is to append instead of overwrite in those plugins.
Ref: https://stackoverflow.com/a/23605812

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Is this change gated behind feature flag(s)?
    • List the LD flags needed to be set to enable this change
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
    • No code change
  • Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes

References

JIRA:

Test & Review

Open questions / Follow-ups

@GunalKupta GunalKupta requested a review from a team as a code owner December 24, 2024 02:52
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@GunalKupta GunalKupta enabled auto-merge (squash) December 24, 2024 02:55
@GunalKupta GunalKupta changed the title Prevent overwriting jacoco execution variable Prevent overwriting argLine execution variable Dec 24, 2024
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (75.40% Estimated after merge)
  • Duplications No duplication information (2.10% Estimated after merge)

Project ID: schema-registry

View in SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant