-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acceptor Dynamic Session Templates #607
Open
pvkv1799
wants to merge
40
commits into
connamara:master
Choose a base branch
from
pvkv1799:wildcard_session
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
0ac7ecc
Merge pull request #1 from connamara/master
pvkv1799 1c0d3a6
Logout can be received when not logged on.
LittleAlexey 4a32702
Redirected stderr to stdout (nul) to avoid confusing message "'pwsh' …
pvkv1799 31e4cd7
comment about where pwsh comes from
gbirchmeier 1aa5da1
fix some typos
gbirchmeier ab6d8c8
don't use "./", don't auto-upload nugets
gbirchmeier cabb0b8
restore RELEASE-README.md... again
gbirchmeier 37e4e3d
fix formatting of RELEASE_README
gbirchmeier ce6691d
Bump NUnit3TestAdapter from 3.16.1 to 3.17.0
dependabot-preview[bot] 7bce47e
incremented version on release notes
gbirchmeier 0ff6970
Don't reflect on non-QF/n assemblies
gbirchmeier 5137896
forgot to own it
gbirchmeier f92bc9f
corrections for ruby 2.5+; some script annotations
gbirchmeier 505907a
remove old unused C++ build
gbirchmeier 45dbc5d
use ruby 2.7 on appveyor
gbirchmeier 9ae84bf
some debugging for ruby on appveyor
gbirchmeier ba756a2
more debugging
gbirchmeier 737b728
change to ruby 2.6, since appveyor's being weird
gbirchmeier 243ddc4
ignore .vscode/
gbirchmeier a0bdc64
add 1156 (ApplExtId) to FIXT11.xml
gbirchmeier edfffa3
stupid copy/paste error in previous commit
gbirchmeier 143da50
Added "AcceptorTemplate" parameter
pvkv1799 e3579b7
Comment
pvkv1799 dc82d51
Added SessionID wildcards handling to FileLog
pvkv1799 d296fcb
Added FileLog unit tests for wildcards
pvkv1799 acd35de
Refactored ThreadedSocketAcceptor unit tests: changed to pass configu…
pvkv1799 d0a14ee
Added SessionID wildcards handling to FileStore;
pvkv1799 622c395
Bug fix: validation of BeginString regardless of Connection Type
pvkv1799 782dfe3
Bug fix in test: wildcards are valid only for acceptor
pvkv1799 1eab2e4
Added logic to create the new session from a template upon receiving …
pvkv1799 52144b3
Added unit tests for dynamic session templates
pvkv1799 56e5584
Removed unused AcceptorTemplate constant
pvkv1799 176dce3
Documentation comments for GetSession
pvkv1799 6af399a
Removed TODO from GetSession
pvkv1799 3bb2a51
Added check for null _acceptor in CreateFromTemplate
pvkv1799 9059892
Improved explanations in comments
pvkv1799 628b77a
Using the new Session constructor with isInitiator
pvkv1799 50005cb
Removed commented ACCEPTOR_TEMPLATE constant
pvkv1799 83f1b83
Renamed GetSession to LookupOrCreateDynamicSession
pvkv1799 2f54fe5
Removed commented-out irrelevant code
pvkv1799 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,7 @@ upload_to_s3.rb | |
*~ | ||
*.suo | ||
.vs/ | ||
.vscode/ | ||
|
||
# ReSharper is a .NET coding add-in | ||
_ReSharper*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly (or all) the same as FileStore.Prefix(). That was fine when they were small, but now I think this common code should be unified. Perhaps a static class & function would be appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do - should I put the new calls in "Util" subfolder of the solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'll work, or it could go in the same dir as FileLog/FileStore. Doesn't really matter to me.