Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ClientHandlerThread debug logs #705

Conversation

jamescoverdale
Copy link

@jamescoverdale jamescoverdale commented Sep 9, 2021

Adds a config flag that disables the creation of ClientHandlerThread debug logs by using a null logger if enabled.

Fixes: #684

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@jamescoverdale jamescoverdale force-pushed the disable_client_handler_debug_logs branch from 3579a6f to c283332 Compare September 9, 2021 15:11
@VAllens
Copy link

VAllens commented Sep 15, 2021

Good idea, when to merge it?

@jamescoverdale
Copy link
Author

@gbirchmeier any chance of getting this merged?

@jamescoverdale jamescoverdale force-pushed the disable_client_handler_debug_logs branch from fb8fb88 to c283332 Compare November 2, 2021 11:04
@gbirchmeier
Copy link
Member

I'm going to put this in the next release, hopefully in the next month or two. Apologies for letting this one sit so long.

@VAllens
Copy link

VAllens commented Mar 22, 2023

expecting

@gbirchmeier
Copy link
Member

I'm working on an alternate solution, begun in #830 which so far eliminates the Debug log for good and (temporarily) writes those logs to console. I'm going to route those logs to something smarter, though I haven't totally decided how that will work yet. (Got a few conflicting ideas in my head, need to decide which is best.)

There are some errors that should be loggable, but not in the hacky way that Debug log works.

@gbirchmeier gbirchmeier closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to turn off logging in ClientHandlerThread?
5 participants