Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#736 Don't create file logs until firm event or message #772

Closed
wants to merge 2 commits into from

Conversation

nmandzyk
Copy link
Contributor

@nmandzyk nmandzyk commented May 8, 2023

#736 Postpone file creation until receiving the first message or event

@CLAassistant
Copy link

CLAassistant commented May 8, 2023

CLA assistant check
All committers have signed the CLA.

@gbirchmeier
Copy link
Member

gbirchmeier commented Jul 13, 2023

What problem is this solving? Is the engine writing empty files or something?

@nmandzyk
Copy link
Contributor Author

What problem is this solving? Is the engine writing empty files or something?

Hey Grant. Before explaining the problem let me describe in short, how our infrastructure looks like. So, we hosts our FIX server in AKS (Azure k8s) and when we expose port to external VNET. Somebody connects to our FIX server and this imediatelly created new instance of FileLogger that created empty file in consturtor. As result we have a lot of empty files but these connection were not FIX connections just some internal k8s helthprobles. So, to avoid empty file creation, I just postpone file creation up to log the first FIX message.

@Oribow
Copy link

Oribow commented Mar 22, 2024

Hi!
Any updates on this? I am facing the exact same issue. What can we do to get this PR or something similar merged?
Not sure how long our hdd will survive this many file creations lol.

@Oribow
Copy link

Oribow commented Apr 2, 2024

Oh I see. @gbirchmeier is doing some more comprehensive reworking of the logging at #830

@gbirchmeier
Copy link
Member

I'm sorry it's still in progress. I'm trying to make the time.

@gbirchmeier
Copy link
Member

PR #830 will finally take care of the ClientHandlerThread logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants