cleanup Logger/Store classes; move them to new namespaces, fix a path-separator bug #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileLog/FileStore now converts back/fwd slashes in configured paths to proper path separators of the platform OS. Interface changes: * FileLog: remove the single-param ctor, no reason for anyone to use it * ScreenLog ctor: removed unused sessionId param * ScreenLogFactory: remove public vars and a ctor that no one should be using
also make them use file-scoped namespace and get rid of the extra indent
also make them use file-scoped namespace and get rid of the extra indent
gbirchmeier
force-pushed
the
nullable-log-and-store
branch
from
6d75b6c
to
9909d22
Compare
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Feb 23, 2024
* restore ScreenLogFactory three-bool constructor (was removed in connamara#831, but I changed my mind) * screen log output now replaces NUL with "|" * new SettingsDictionary::IsBoolPresentAndTrue() function * added ScreenLog settings to tradeclient config
Merged
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Feb 23, 2024
* restore ScreenLogFactory three-bool constructor (was removed in connamara#831, but I changed my mind) * screen log output now replaces NUL with "|" * new SettingsDictionary::IsBoolPresentAndTrue() function * added ScreenLog settings to tradeclient config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileStore/FileLog now convert back/fwd slashes in the configured path to be appropriate for the OS platform. (e.g. convert forward-slashes to backslash on Windows, and vice-versa on not-Windows)
Also do enable-nullable and general cleanup on all the Logger/Store classes.
Interface changes: