Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #878: corrections to DD enums for Side #879

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix #878: corrections to DD enums for Side #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions QuickFIXn/Fields/Fields.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,8 +1286,6 @@ public Side(char val)
public const char REDEEM = 'E';
public const char LEND = 'F';
public const char BORROW = 'G';
public const char CROSS_SHORT_EXXMPT = 'A';
public const char D = '7';
}


Expand Down
7 changes: 7 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ What's New
* **There are breaking changes between 1.10 and 1.11! Please review the 1.11.0 notes below.**


### (next release)

**Breaking changes**
* #878 - corrections to tag 45 "Side" in various DDs (gbirchmeier)
* fix typo in FIX50 and FIX50SP1: `CROSS_SHORT_EXXMPT` fixed to `CROSS_SHORT_EXEMPT`
* correction in FIX41 and FIX42: `D` to `UNDISCLOSED`

### v1.12.0

**Breaking changes**
Expand Down
2 changes: 1 addition & 1 deletion spec/fix/FIX41.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,7 @@
<value enum="4" description="SELL_PLUS"/>
<value enum="5" description="SELL_SHORT"/>
<value enum="6" description="SELL_SHORT_EXEMPT"/>
<value enum="7" description="D"/>
<value enum="7" description="UNDISCLOSED"/>
<value enum="8" description="CROSS"/>
</field>
<field number="55" name="Symbol" type="STRING"/>
Expand Down
2 changes: 1 addition & 1 deletion spec/fix/FIX42.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1796,7 +1796,7 @@
<value enum="4" description="SELL_PLUS"/>
<value enum="5" description="SELL_SHORT"/>
<value enum="6" description="SELL_SHORT_EXEMPT"/>
<value enum="7" description="D"/>
<value enum="7" description="UNDISCLOSED"/>
<value enum="8" description="CROSS"/>
<value enum="9" description="CROSS_SHORT"/>
</field>
Expand Down
2 changes: 1 addition & 1 deletion spec/fix/FIX50.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4776,7 +4776,7 @@
<value enum='7' description='UNDISCLOSED' />
<value enum='8' description='CROSS' />
<value enum='9' description='CROSS_SHORT' />
<value enum='A' description='CROSS_SHORT_EXXMPT' />
<value enum='A' description='CROSS_SHORT_EXEMPT' />
<value enum='B' description='AS_DEFINED' />
<value enum='C' description='OPPOSITE' />
<value enum='D' description='SUBSCRIBE' />
Expand Down
2 changes: 1 addition & 1 deletion spec/fix/FIX50SP1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5523,7 +5523,7 @@
<value enum='7' description='UNDISCLOSED' />
<value enum='8' description='CROSS' />
<value enum='9' description='CROSS_SHORT' />
<value enum='A' description='CROSS_SHORT_EXXMPT' />
<value enum='A' description='CROSS_SHORT_EXEMPT' />
<value enum='B' description='AS_DEFINED' />
<value enum='C' description='OPPOSITE' />
<value enum='D' description='SUBSCRIBE' />
Expand Down
Loading