V2: Ensure that a signal exists for a completed RPC (#1282)

packages/connect/src/implementation.spec.ts

@@ -68,17 +68,12 @@ describe("createHandlerContext()", function () {
       expect(ctx.signal.aborted).toBeTrue();
       expect(ctx.signal.reason).toBe("shutdown-signal");
     });
-    it("should trigger on abort with reason", function () {
+    it("should trigger on abort", function () {
       const ctx = createHandlerContext({ ...standardOptions });
       ctx.abort("test-reason");
       expect(ctx.signal.aborted).toBeTrue();
       expect(ctx.signal.reason).toBe("test-reason");
     });
-    it("should not trigger on abort without reason", function () {
-      const ctx = createHandlerContext({ ...standardOptions });
-      ctx.abort();
-      expect(ctx.signal.aborted).toBeFalse();
-    });
   });
 
   describe("timeout()", function () {

packages/connect/src/implementation.ts

@@ -68,8 +68,9 @@ export interface HandlerContext {
   readonly service: DescService;
 
   /**
-   * An AbortSignal that triggers when the deadline is reached, or when an
-   * error occurs that aborts processing of the request.
+   * An AbortSignal that triggers when the deadline is reached, or when an error
+   * occurs that aborts processing of the request, but also when the RPC is
+   * completed without error.
    *
    * The signal can be used to automatically cancel downstream calls.
    */
@@ -175,9 +176,7 @@ export function createHandlerContext(
     responseTrailer: new Headers(init.responseTrailer),
     abort(reason?: unknown) {
       deadline.cleanup();
-      if (reason !== undefined) {
-        abortController.abort(reason);
-      }
+      abortController.abort(reason);
     },
     values: init.contextValues ?? createContextValues(),
   };