Cleanup receiver names and remove most nolints (#76)

.golangci.yml

@@ -65,6 +65,22 @@ issues:
     # checks from err113 are useful.
     - "err113: do not define dynamic errors.*"
   exclude-rules:
-    - path: internal/examples/pets/.*\.go
+    - path: internal/examples/.*/.*\.go
       linters:
         - forbidigo # log.Fatal, fmt.Printf used in example programs
+        - gosec
+        - gochecknoglobals
+    - path: ".*_test.go"
+      linters:
+        - dupl # allow duplicate string literals for testing
+        - forcetypeassert
+        - nilerr # allow encoding error and returning nil
+    - path: vanguard_examples_test.go
+      linters:
+        - gocritic # allow log.Fatal for examples
+    - path: handler.go
+      linters:
+        - contextcheck # use request context
+    - path: params.go
+      linters:
+        - goconst # allow string literals for WKT names

buffer_pool.go

@@ -29,24 +29,21 @@ type bufferPool struct {
 }
 
 func newBufferPool() *bufferPool {
-	return &bufferPool{
-		Pool: sync.Pool{
-			New: func() any {
-				return bytes.NewBuffer(make([]byte, 0, initialBufferSize))
-			},
-		},
-	}
+	return &bufferPool{}
 }
 
 func (b *bufferPool) Get() *bytes.Buffer {
-	return b.Pool.Get().(*bytes.Buffer) //nolint:forcetypeassert
+	if buffer, ok := b.Pool.Get().(*bytes.Buffer); ok {
+		buffer.Reset()
+		return buffer
+	}
+	return bytes.NewBuffer(make([]byte, 0, initialBufferSize))
 }
 
 func (b *bufferPool) Put(buffer *bytes.Buffer) {
 	if buffer.Cap() > maxRecycleBufferSize {
 		return
 	}
-	buffer.Reset()
 	b.Pool.Put(buffer)
 }
 

compression.go

@@ -72,7 +72,7 @@ func (p *compressionPool) compress(dst, src *bytes.Buffer) error {
 	if src.Len() == 0 {
 		return nil
 	}
-	comp := p.compressors.Get().(connect.Compressor) //nolint:forcetypeassert,errcheck
+	comp, _ := p.compressors.Get().(connect.Compressor)
 	defer p.compressors.Put(comp)
 
 	comp.Reset(dst)
@@ -91,7 +91,7 @@ func (p *compressionPool) decompress(dst, src *bytes.Buffer) error {
 	if src.Len() == 0 {
 		return nil
 	}
-	decomp := p.decompressors.Get().(connect.Decompressor) //nolint:forcetypeassert,errcheck
+	decomp, _ := p.decompressors.Get().(connect.Decompressor)
 	defer p.decompressors.Put(decomp)
 
 	if err := decomp.Reset(src); err != nil {