Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test coverage for use of
httputil.ReverseProxy
. Currently onRead
when we return a nonio.EOF
error it will cause the handler to panic which will incorrectly bubble up to the handler without encoding the error. Now we first report the error on prepare message before erroring the read withio.EOF
.Issues:
aborts the stream with the connect error given in the read. Should instead return
io.EOF
and cancel the context.