Migrate buf configuration files to v2 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/bufConfigV2
branch
from
1105d2e to
f784682
Compare
Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/bufConfigV2
branch
from
f09d82b to
486d166
Compare
emcfarlane
commented
May 22, 2024
nicksnyder
requested review from
smallsamantha
and removed request for
nicksnyder
jhump
reviewed
May 23, 2024
Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/bufConfigV2
branch
from
26dd48b to
75af642
Compare
Signed-off-by: Edward McFarlane <[email protected]>
Signed-off-by: Edward McFarlane <[email protected]>
doriable
reviewed
May 29, 2024
Comment on lines
+21
to
+22
| - RPC_REQUEST_RESPONSE_UNIQUE | ||
| - RPC_RESPONSE_STANDARD_NAME |
There was a problem hiding this comment.
Should this also include RPC_REQUEST_STANDARD_NAME?
There was a problem hiding this comment.
Currently not needed, so removed to reduce excepts.
doriable
approved these changes
May 29, 2024
jhump
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
buf config migratemigrating thebufconfiguration files to v2. Small cleanup to remove unnecessary rules and added the examples to the code generation.