Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rules options to mux to specify custom HTTP rules #74

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

emcfarlane
Copy link
Collaborator

@emcfarlane emcfarlane commented Sep 21, 2023

Lets users specify additional HTTP rules via a RegisterRules func.

Fixes TCN-2374

@emcfarlane emcfarlane requested a review from jhump September 21, 2023 13:29
@emcfarlane emcfarlane self-assigned this Sep 21, 2023
vanguard.go Outdated Show resolved Hide resolved
vanguard.go Outdated Show resolved Hide resolved
vanguard.go Outdated Show resolved Hide resolved
@emcfarlane emcfarlane requested a review from jhump September 22, 2023 14:32
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions. Otherwise LGTM

vanguard.go Outdated Show resolved Hide resolved
vanguard.go Outdated Show resolved Hide resolved
@emcfarlane emcfarlane merged commit c5eb1db into main Sep 25, 2023
4 checks passed
@emcfarlane emcfarlane deleted the ed/rules branch September 25, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants