Drop AsHandler method from Mux #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
force-pushed
the
ed/muxserve
branch
from
5cc5f28 to
bbda0fd
Compare
bufdev
approved these changes
Sep 27, 2023
| @@ -110,30 +112,30 @@ type JSONCodec struct { | |||
| UnmarshalOptions protojson.UnmarshalOptions | |||
| } | |||
|
|
|||
| var _ StableCodec = (*JSONCodec)(nil) | |||
| var _ RESTCodec = (*JSONCodec)(nil) | |||
| var _ StableCodec = JSONCodec{} | |||
There was a problem hiding this comment.
This looks unrelated and not sure we need to do it, but not blocking for now since we're reviewing the Codec interfaces separately.
There was a problem hiding this comment.
It removes having to have the cache to convert codecs from a map[string] func(TypeResolver) Codec to map[codecKey]Codec where the codecKey is a type of struct{string, TypeResolver} which means we can drop the constructor for the handler.
There was a problem hiding this comment.
It's a little less efficient, could move the cache to the methodConfig but if we are changing the codec layout easier to call the factory func.
emcfarlane
force-pushed
the
ed/muxserve
branch
from
bbda0fd to
c139bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.