Move internal/examples to examples folder #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
commented
Sep 29, 2023
| @@ -4,5 +4,5 @@ deps: | |||
| - remote: buf.build | |||
| owner: googleapis | |||
| repository: googleapis | |||
| commit: 711e289f6a384c4caeebaff7c6931ade | |||
There was a problem hiding this comment.
Had conflicting lock file versions, made them all the same.
emcfarlane
force-pushed
the
ed/mv-examples
branch
from
1404a29 to
dadedcc
Compare
|
I think we could do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
buf generatework, all protos are generated tointernal/gen. Moves examples to top level for easier visibilty. Any go packages can be moved to internal folders in the separate packages.