Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes most TODO #82

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Fixes most TODO #82

merged 5 commits into from
Oct 12, 2023

Conversation

emcfarlane
Copy link
Collaborator

@emcfarlane emcfarlane requested a review from jhump October 4, 2023 21:14
@emcfarlane emcfarlane self-assigned this Oct 4, 2023
jhump
jhump reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LG, but there are some changes I don't quite follow.

protocol_grpc.go Outdated Show resolved Hide resolved
protocol_rest.go Outdated Show resolved Hide resolved
protocol_rest.go Outdated Show resolved Hide resolved
protocol_rest.go Outdated Show resolved Hide resolved
protocol_rest.go Show resolved Hide resolved
protocol_rest.go Outdated Show resolved Hide resolved
@emcfarlane emcfarlane merged commit 5517025 into main Oct 12, 2023
@emcfarlane emcfarlane deleted the ed/todos branch October 12, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump approved these changes

Assignees

@emcfarlane emcfarlane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emcfarlane @jhump