Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min/max for protocol iteration #93

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Remove min/max for protocol iteration #93

merged 8 commits into from
Oct 24, 2023

Conversation

emcfarlane
Copy link
Collaborator

No description provided.

@emcfarlane emcfarlane requested a review from jhump October 23, 2023 20:55
transcoder.go Outdated Show resolved Hide resolved
transcoder.go Outdated Show resolved Hide resolved
protocol.go Outdated Show resolved Hide resolved
@emcfarlane emcfarlane requested a review from jhump October 24, 2023 14:14
protocol.go Outdated Show resolved Hide resolved
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks for improvement. Otherwise LGTM.

transcoder.go Outdated Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
@emcfarlane emcfarlane merged commit a932187 into main Oct 24, 2023
4 checks passed
@emcfarlane emcfarlane deleted the ed/min-max branch October 24, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants