Read in additional sorts from query properties #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvera
reviewed
May 27, 2020
| @@ -379,6 +396,9 @@ private Object query(Map<String, Object> params) { | |||
| } | |||
|
|
|||
| Map<String, Serializable> properties = new HashMap<>(); | |||
| if (params.containsKey("properties")) { | |||
There was a problem hiding this comment.
Was this key just not being used before?
There was a problem hiding this comment.
Yes, it is always passed empty when constructing the queryRequest sent to the catalogFramework query method https://github.com/connexta/ddf-jsonrpc/blob/master/src/main/java/com/connexta/ddf/catalog/direct/CatalogMethods.java#L384-L409
There was a problem hiding this comment.
^ Here is an example queryRequest to the catalogFramework not using the rpc
I think we will have to update the getProperties method to also read in other properties as well https://github.com/connexta/ddf-jsonrpc/pull/20/files#diff-4b8f31c7553886d543ac3f68641f3f4eR296
gjvera
approved these changes
May 28, 2020
willwill96
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.