-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscription Rework and multiple version support #31
Conversation
ddf-rpc-api/pom.xml
Outdated
log-sanitizer | ||
</Embed-Dependency> | ||
<!-- | ||
org.codice.ddf.log.sanitizer;version="[2.19,3)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
ddf-rpc-api/pom.xml
Outdated
org.opengis.filter.expression;version="[19.1.0,21.0.0)", | ||
org.apache.commons.lang3;version="[3.8.0,4.0.0)", | ||
org.apache.commons.lang3.tuple;version="[3.8.0,4.0.0)", | ||
ddf.security;version="[2.19,3)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if this is removeable or if the transitive dependency powers that be require us specify this
ddf-rpc-api/src/main/java/com/connexta/ddf/persistence/subscriptions/SubscriptionMethods.java
Outdated
Show resolved
Hide resolved
ddf-rpc-api/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Outdated
Show resolved
Hide resolved
ddf-rpc-api/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Outdated
Show resolved
Hide resolved
email/2.19-email-impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Outdated
Show resolved
Hide resolved
Tested all methods against 2.19 and master (currently 2.27-SNAPSHOT) successfully |
5384915
to
fbd5cfa
Compare
ddf-rpc-api/src/main/java/com/connexta/ddf/persistence/subscriptions/SubscriptionMethods.java
Show resolved
Hide resolved
Verified that this works with ddf 2.23.2 as well |
ddf-rpc-api/src/main/java/com/connexta/ddf/catalog/direct/CatalogMethods.java
Show resolved
Hide resolved
email/2.19-email-impl/src/main/resources/OSGI-INF/blueprint/blueprint.xml
Show resolved
Hide resolved
e90e924
to
7d3bb10
Compare
CI build passed ✅ 🎉 |
Remaining to do/possible changes
2.26
nomenclature to 2.24+/2.25+ depending on which is supported.Closes #24
Overview
jsonrpc-2.19
andjsonrpc-2.26
Bundle changes
New Bundles:
Blueprint changes
email-service
Structural changes