Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PgSQL driver to enable mapping #262

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update PgSQL driver to enable mapping #262

wants to merge 12 commits into from

Conversation

mreiden
Copy link
Contributor

@mreiden mreiden commented Jun 19, 2019 •
edited
Loading

PgSQL driver updates to allow DB <-> QuickBooks mapping feature.

  • Lowercase table, column, and index names due to postgres case-folding names to lowercase unless they are quoted. They were quoted during table creation but not insert/update resulting in "ERROR: column "refnumber" does not exist. HINT: Perhaps you meant to reference the column "RefNumber" errors. (Solves PR Lowercase Table Names for PGSQL #39).
  • Create timestamp columns as timestamp without time zone instead of TEXT by adding a missing break in case statement.
  • Handle QUICKBOOKS_DRIVER_SQL_DATE to create date columns as DATE instead of TEXT.
  • Add hasTrueBoolean method to SQL Drivers to use true/false values instead of 1/0 for PgSQL. PgSQL does not accept 1/0 for Boolean.
  • Use class constants instead of undefined constants in mirroring examples.

Successful mapping depends on QuickBooks_Map_Qbxml class name capitalization change in PR #261.

This PR is based on top of the whitespace removal in #258.

@mreiden
Remove trailing whitespace.
65790e8
@mreiden
Consistently use a single trailing newline at end of file.
784ebc8
@mreiden
Remove php closing tags from class files.
4cdd159
@mreiden
Remove ending php tags from 2 overlooked files.
cdebbf0
@mreiden
Replace MySQL with PgSQL in DocBlocks.
738e7a2
@mreiden
Fix Date/DateTime FieldSchema by adding a missing break/return. Remov…
5a688d7 
…e commented out QUICKBOOKS_DRIVER_SQL_BOOLEAN MySql case (PgSQL version remains above) that accidentally included the return $sql.
@mreiden
Use break instead of return for consistency.
83e68f6
@mreiden
PgSQL lacked a QUICKBOOKS_DRIVER_SQL_DATE case and used default case …
47ed95d 
…of TEXT datatype.
@mreiden
Use class constants QuickBooks_WebConnector_Server_SQL::MODE_READONLY…
9ba1c04 
…, QuickBooks_WebConnector_Server_SQL::MODE_WRITEONLY, and QuickBooks_WebConnector_Server_SQL::MODE_READWRITE instead of undefined QUICKBOOKS_SERVER_SQL_MODE_READONLY, QUICKBOOKS_SERVER_SQL_MODE_WRITEONLY, and QUICKBOOKS_SERVER_SQL_MODE_READWRITE in example_mssql_mirror.php and example_pgsql_mirror.php.
@mreiden
Lowercase PgSQL table, column, and index names (PgSQL lowercases Colu…
81e483d 
…mn and requires quotes for CoLuMn and you can actually create both in the same table if you want to cause mass confusion). Successful mapping depends on PR consolibyte#261.  Cleaned up version solves PR consolibyte#39.
@mreiden
Add method hasTrueBoolean to QuickBooks_Driver_Sql and use true/false…
ba5a889 
… values for booleans in Pgsql driver and 1/0 for the other drivers.
@mreiden
Update mirroring examples to use class constants instead of undefined…
311e3fc 
… QUICKBOOKS_SERVER_SQL_CONFLICT_LOG and QUICKBOOKS_SERVER_SQL_DELETE_FLAG in PgSQL and Microsoft SQL. Use the same $mode and $delete settings as are in the MySQL example for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mreiden