Allow making instances of BitVec
with B≠u32
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not possible to construct such instances of
BitVec
other than via theDefault
trait. Using the*_general
methods, one can construct instances ofBitVec
with arbitraryB
. See the examples in the doc comments for the syntax.In particular the
with_capacity
function is now available for arbitraryB
.I'm not certain about the following parts and would like some input or changes by the maintainer:
u32
made use of the|=
operator (ops::BitOrAssign
). I didn't want to change this code, so I addedBitOrAssign
as requirement for theBitBlock
trait. By replacinga |= b
with its equivalent forma = a | b
, this requirement could be removed.I haven't checked, whether there is a similar situation in other libraries.