Adding Yarn v1.x workspaces metadata extractor #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylormadore
reviewed
Oct 8, 2024
a-ovchinnikov
force-pushed
the
yarn_workspace_metadata
branch
from
4539e89
to
5c27f9e
Compare
eskultety
reviewed
Oct 16, 2024
a-ovchinnikov
force-pushed
the
yarn_workspace_metadata
branch
from
5c27f9e
to
ce87ae4
Compare
eskultety
reviewed
Oct 18, 2024
eskultety
reviewed
Oct 18, 2024
eskultety
reviewed
Oct 18, 2024
eskultety
reviewed
Oct 18, 2024
A model to handle yarn workspaces is added. Workspaces allow user to install dependencies from multiple package.json files within one root package. Official workspaces definition: https://classic.yarnpkg.com/lang/en/docs/workspaces/ Signed-off-by: Alexey Ovchinnikov <[email protected]>
In Yarn v1.x workspaces metadata is stored outside of yarn.lock in package.json. This commit inroduces functions for workspaces metadata extraction and a dataclass to represent workspaces. Signed-off-by: Alexey Ovchinnikov <[email protected]>
a-ovchinnikov
force-pushed
the
yarn_workspace_metadata
branch
from
ce87ae4
to
99c48f0
Compare
eskultety
reviewed
Oct 18, 2024
It turns out that workspaces could be either Array or a nested Array in an Object thus we must handle both cases. Official docs mentioning the former: https://classic.yarnpkg.com/lang/en/docs/workspaces/ Official blog containing a hint about the latter: https://classic.yarnpkg.com/lang/en/docs/workspaces/ Signed-off-by: Alexey Ovchinnikov <[email protected]>
a-ovchinnikov
force-pushed
the
yarn_workspace_metadata
branch
from
99c48f0
to
3296fa5
Compare
eskultety
approved these changes
Oct 18, 2024
taylormadore
approved these changes
Oct 21, 2024
Merged
via the queue into
containerbuildsystem:main
with commit Oct 21, 2024
746bdfe
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Yarn v1.x workspaces metadata is stored outside of yarn.lock in package.json. This commit inroduces functions for workspaces metadata extraction and a dataclass to represent workspaces.
This addresses #630
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)