-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Replace "localhost" domain name with the equivalent IPv4 address #678
tests: Replace "localhost" domain name with the equivalent IPv4 address #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Did you mean to use your clone of cachito-testing-cachi2-pip-custom-index?
- Should we make the local v4 IP a global (instead of hardcoding everywhere)?
Otherwise, LGTM
I can create a global variable for that if desired. |
520068d
to
100045f
Compare
Integration tests for pip passed (the failures are unrelated), so I'm going to merge cachito-testing/cachi2-pip-custom-index@e3916a8, update this one and hopefully merge so that no other PRs are disrupted by the change in tests. |
It's common that "localhost" translates with both IPv4 and IPv6. The simple containerized test PyPI server we use in our CI doesn't listen on IPv6 which may cause unpredictable issues on hosts where IPv6 is enabled and IPv6 would get prioritized by the low level network stack connection primitives. Therefore, use an IP explicitly to avoid any potential issues during pytest run, e.g.: DEBUG Starting new HTTP connection (1): localhost:8080 DEBUG ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')) Signed-off-by: Erik Skultety <[email protected]>
100045f
to
28fbf0f
Compare
b289c91
It's common that "localhost" translates with both IPv4 and IPv6. The simple containerized test PyPI server we use in our CI doesn't listen on IPv6 which may cause unpredictable issues on hosts where IPv6 is enabled and IPv6 would get prioritized by the low level network stack connection primitives. Therefore, use an IP explicitly to avoid any potential issues during pytest run, e.g.:
PR depends on: cachito-testing/cachi2-pip-custom-index#1
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)