Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic fetcher: Add lockfile #681

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kosciCZ
Copy link
Contributor

@kosciCZ kosciCZ commented Oct 9, 2024

This commit adds custom lockfile for the generic feature, used in order to specify list of files to download and checksums to verify against.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Docs updated (if applicable)
  • Docs links in the code are still valid (if docs were updated)

Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:

@brunoapimentel
Copy link
Contributor

/ok-to-test

cachi2/core/package_managers/generic.py Outdated Show resolved Hide resolved
cachi2/core/package_managers/generic.py Outdated Show resolved Hide resolved
cachi2/core/package_managers/generic.py Outdated Show resolved Hide resolved
tests/unit/package_managers/test_generic.py Outdated Show resolved Hide resolved
@kosciCZ kosciCZ force-pushed the add-generic-lockfile branch 2 times, most recently from 555f8ea to 5bdac1a Compare October 11, 2024 15:27
Copy link
Member

@eskultety eskultety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I pretty much only raised nitpicks, but since I requested the changes to be split logically into more commits I raised these anyway since you'd be touching the code in the process of doing that.

cachi2/core/package_managers/generic/main.py Outdated Show resolved Hide resolved
cachi2/core/package_managers/generic/models.py Outdated Show resolved Hide resolved
tests/unit/package_managers/test_generic.py Outdated Show resolved Hide resolved
tests/unit/package_managers/test_generic.py Outdated Show resolved Hide resolved
tests/unit/package_managers/test_generic.py Outdated Show resolved Hide resolved
Adds pydantic models that will be used to represent and validate
the lockfile for the generic fetcher.

Signed-off-by: Jan Koscielniak <[email protected]>
Copy link
Member

@eskultety eskultety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment on reducing the logging noise, adding my ACK regardless.

cachi2/core/package_managers/generic/main.py Outdated Show resolved Hide resolved
This commit adds functionality to load custom lockfile for the generic
fetcher.

Signed-off-by: Jan Koscielniak <[email protected]>
@kosciCZ
Copy link
Contributor Author

kosciCZ commented Oct 15, 2024

Thank you for your review and approvals! Can someone please merge?

@eskultety eskultety added this pull request to the merge queue Oct 15, 2024
Merged via the queue into containerbuildsystem:main with commit c94a1a2 Oct 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants