-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic fetcher: Add lockfile #681
Generic fetcher: Add lockfile #681
Conversation
/ok-to-test |
ec079dc
to
1b5271d
Compare
555f8ea
to
5bdac1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I pretty much only raised nitpicks, but since I requested the changes to be split logically into more commits I raised these anyway since you'd be touching the code in the process of doing that.
Adds pydantic models that will be used to represent and validate the lockfile for the generic fetcher. Signed-off-by: Jan Koscielniak <[email protected]>
5bdac1a
to
0059a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny comment on reducing the logging noise, adding my ACK regardless.
This commit adds functionality to load custom lockfile for the generic fetcher. Signed-off-by: Jan Koscielniak <[email protected]>
0059a58
to
8ac96de
Compare
Thank you for your review and approvals! Can someone please merge? |
c94a1a2
This commit adds custom lockfile for the generic feature, used in order to specify list of files to download and checksums to verify against.
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test
(as is the standard for Pipelines as Code)