yarn: Universal utility for Yarn version detection #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-ovchinnikov
force-pushed
the
issue660
branch
from
6101de6
to
00c6637
Compare
a-ovchinnikov
force-pushed
the
issue660
branch
from
00c6637
to
d016fc3
Compare
eskultety
reviewed
Oct 23, 2024
a-ovchinnikov
force-pushed
the
issue660
branch
from
d016fc3
to
10885e1
Compare
eskultety
reviewed
Oct 23, 2024
slimreaper35
approved these changes
Oct 23, 2024
taylormadore
approved these changes
Oct 23, 2024
a-ovchinnikov
force-pushed
the
issue660
branch
from
10885e1
to
30f3758
Compare
eskultety
reviewed
Oct 23, 2024
a-ovchinnikov
force-pushed
the
issue660
branch
from
30f3758
to
2e238ed
Compare
eskultety
approved these changes
Oct 24, 2024
| @@ -118,7 +118,7 @@ def _configure_yarn_version(project: Project) -> None: | |||
| yarn_path_version = get_semver_from_yarn_path(project.yarn_rc.yarn_path) | |||
| package_manager_version = get_semver_from_package_manager(project.package_json.package_manager) | |||
|
|
|||
| if not yarn_path_version and not package_manager_version: | |||
| if yarn_path_version is None and package_manager_version is None: | |||
There was a problem hiding this comment.
Unrelated PEP correctness check update --> separate commit.
The function will be made into a shared utility and used to refactor yarn_classic in future commits. Signed-off-by: Alexey Ovchinnikov <[email protected]>
And making Yarn PM use it. Signed-off-by: Alexey Ovchinnikov <[email protected]>
This change makes yarn-classic reuse version extraction code from yarn. Signed-off-by: Alexey Ovchinnikov <[email protected]>
This change introduces VersionRange class to simplify checks for version belonging to a range of versions. Signed-off-by: Alexey Ovchinnikov <[email protected]>
Now Version is checked against VersionsRange object. Signed-off-by: Alexey Ovchinnikov <[email protected]>
This commit makes Yarn PM a bit more PEP8 compliant by replacing two implied None checks with explicit ones. Signed-off-by: Alexey Ovchinnikov <[email protected]>
a-ovchinnikov
force-pushed
the
issue660
branch
from
2e238ed
to
509eedf
Compare
Merged
via the queue into
containerbuildsystem:main
with commit Oct 24, 2024
5ad6baf
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies handling of version info for Yarn and Yarn Classic package managers.
Resolves: #660
Maintainers will complete the following section
Note: if the contribution is external (not from an organization member), the CI
pipeline will not run automatically. After verifying that the CI is safe to run:
/ok-to-test(as is the standard for Pipelines as Code)