Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dockerfile: bump library/node from 22.9.0-bullseye to 23.0.0-bullseye" #703

Conversation

a-ovchinnikov
Copy link
Collaborator

Reverts #695

A breaking change slipped in and now yarn complains about package checksums when it is not supposed to (see https://github.com/containerbuildsystem/cachi2/actions/runs/11461916749/job/31900425880?pr=686 for an example). Let's revert the change until we figure out what exactly has to be done with e2e tests and merge #702 in the meantime.

Copy link
Contributor

@taylormadore taylormadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a signoff

Copy link
Member

@ben-alkov ben-alkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above 😁

@a-ovchinnikov
Copy link
Collaborator Author

I messed this one up and will close it now. #704 is essentially the same, but done properly.

@eskultety eskultety deleted the revert-695-dependabot/docker/library/node-23.0.0-bullseye branch October 25, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants