Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runc.Features(ctx) to wrap runc features #97

Merged
merged 1 commit into from
May 17, 2023

Conversation

AkihiroSuda
Copy link
Member

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 55.55% and project coverage change: +0.70 🎉

Comparison is base (f5d58d0) 20.69% compared to head (d20f83b) 21.40%.

❗ Current head d20f83b differs from pull request most recent head 6d29289. Consider uploading reports for the commit 6d29289 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   20.69%   21.40%   +0.70%     
==========================================
  Files           7        7              
  Lines         715      724       +9     
==========================================
+ Hits          148      155       +7     
- Misses        527      528       +1     
- Partials       40       41       +1     
Impacted Files Coverage Δ
runc.go 21.78% <55.55%> (+0.76%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AkihiroSuda
Copy link
Member Author

Can we release go-runc v1.1.0 after merging this?

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Member

fuweid commented May 17, 2023

Can we release go-runc v1.1.0 after merging this?

SGTM

@dmcgowan dmcgowan merged commit df3c22d into containerd:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants