Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go module to imgcrypt v2 #168

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

dmcgowan
Copy link
Member

Allow importing of containerd v2 without breaking compatibility for use with containerd v1.

For consideration of creating v2.0.0 tag over v1.2.0 to allow continued use with containerd 1.x.

Note there is no need for cmd module to also go to v2 but it could be considered as well.

Allow importing of containerd v2 without breaking compatibility for
use with containerd v1.

Signed-off-by: Derek McGowan <[email protected]>
@stefanberger stefanberger merged commit ed83e83 into containerd:main Oct 24, 2024
8 checks passed
@stefanberger
Copy link
Contributor

Thanks.

@AkihiroSuda
Copy link
Member

Can we tag a new version?

@stefanberger
Copy link
Contributor

Can we tag a new version?

Latest tag is v1.2.0-rc1. Now tag it with v1.2.0?

@stefanberger
Copy link
Contributor

Can we tag a new version?

Latest tag is v1.2.0-rc1. Now tag it with v1.2.0?

Actually, maybe only v1.2.0-rc2 now that it depends on a contained rc still github.com/containerd/containerd/v2 v2.0.0-rc.6.

@AkihiroSuda
Copy link
Member

IIUC the intent of this PR is to have v2.0.0[-rc.0]

@stefanberger
Copy link
Contributor

IIUC the intent of this PR is to have v2.0.0[-rc.0]

Well, we are still depending on v2.0.0-rc.6 of containerd. Because of this we probably still have to work with an rc. And you mean imgcrypt should pick up the version number of upcoming containerd, so tag it with v2.0.0-rc.1 instread of v.1.2.0-rc2?

@AkihiroSuda
Copy link
Member

IIUC the intent of this PR is to have v2.0.0[-rc.0]

Well, we are still depending on v2.0.0-rc.6 of containerd. Because of this we probably still have to work with an rc. And you mean imgcrypt should pick up the version number of upcoming containerd, so tag it with v2.0.0-rc.1 instread of v.1.2.0-rc2?

Yes, as this is a breaking change of the Go API
(So, imgcrypt v2.1 won't need to be synced with containerd v2.1)

@stefanberger
Copy link
Contributor

I tagged it now with v2.0.0-rc.1.

@AkihiroSuda
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants