Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: golangci is broken with go canary (1.24RC) #3761

Open
apostasie opened this issue Dec 13, 2024 · 1 comment
Open

CI: golangci is broken with go canary (1.24RC) #3761

apostasie opened this issue Dec 13, 2024 · 1 comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim

Comments

@apostasie
Copy link
Contributor

Description

The core of the issue is that golangci is unable to work properly with a go version that is higher than the one it has been built with, resulting in hogging memory / CPU.

This can be reproduced locally on a laptop:

  • install go 1.24RC
  • download binary curl -sSfLO https://github.com/golangci/golangci-lint/releases/download/v1.62.2/golangci-lint-1.62.2-darwin-arm64.tar.gz

Then:

dmp@Synchronicity:~/Projects/go/nerd/nerdctl$ go version
go version go1.24rc1 darwin/arm64

dmp@Synchronicity:~/Projects/go/nerd/nerdctl$ time GOOS=linux /Users/dmp/tmp/golangci-lint-1.62.2-darwin-arm64/golangci-lint run
^C^C

real	2m10.275s
user	5m25.968s
sys	3m23.894s

vs.

dmp@Synchronicity:~/Projects/go/nerd/nerdctl$ go version
go version go1.23.4 darwin/arm64

dmp@Synchronicity:~/Projects/go/nerd/nerdctl$ time GOOS=linux /Users/dmp/tmp/golangci-lint-1.62.2-darwin-arm64/golangci-lint run

real	0m27.558s
user	1m38.488s
sys	0m47.445s

I have no idea what kind of voodoo golangci is doing, but clearly their binary installs are not usable for our purpose.

Solutions are either: the golangci github action offers to build / install instead of downloading pre-built (and that would work with go1.24), or we figure out how to install manually and remove the action, or we stop linting for canary (would be sad...).

It is unclear to me ATM if there will be unforeseen issues with 1.24 wrt golangci - from a glimpse, it seems that it is just fine and maps are just sugar.

Steps to reproduce the issue

No response

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Dec 13, 2024
@apostasie apostasie changed the title golangci is broken with go canary (1.24RC) CI: golangci is broken with go canary (1.24RC) Dec 13, 2024
@apostasie
Copy link
Contributor Author

Added notes:

  • golangci DOES compile just fine against golang 1.24
  • using the action to go install is a no-go, as you cannot separate GOOS for install and runtime phases... :/

The action install mechanism does not provide much value.

Suggesting we just drop that part and install normally.

This was referenced Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/unconfirmed-bug-claim Unconfirmed bug claim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant