Skip to content

Commit

Permalink
Merge pull request #113 from askervin/5XD_ci_check_generated
Browse files Browse the repository at this point in the history
ci: verify that code generation works and results match
  • Loading branch information
mikebrow authored Oct 1, 2024
2 parents 668be88 + f74ce31 commit 7b3bcee
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,22 @@ jobs:
run: |
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
- name: Install protoc and plugins
run: |
sudo make install-protoc
make install-protoc-dependencies install-ttrpc-plugin
- name: Force regeneration of protobuf files on build
run: |
touch pkg/api/api.proto
- run: |
make all
- name: Validate files in git have not been changed
run: |
make validate-repo-no-changes
linters:
name: Linters
runs-on: ${{ matrix.os }}
Expand Down
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ vet:
golangci-lint:
$(Q)$(GOLANG_CILINT) run

validate-repo-no-changes:
$(Q)test -z "$$(git status --short | tee /dev/stderr)" || { \
echo "Repository has changes."; \
echo "Please make sure to commit all changes, including generated files."; \
exit 1; \
}

#
# proto generation targets
#
Expand Down

0 comments on commit 7b3bcee

Please sign in to comment.