[release/0.1 backport] remove containerd as dependency #58
Conversation
go.mod
Outdated
| @@ -3,14 +3,6 @@ module github.com/containerd/nri | |||
| go 1.14 | |||
|
|
|||
| require ( | |||
| // when updating containerd, adjust the replace rules accordingly | |||
| github.com/containerd/containerd v1.5.0-beta.3 | |||
| github.com/opencontainers/runtime-spec v1.0.3-0.20200929063507-e6143ca7d51d | |||
There was a problem hiding this comment.
This is the version that was used by containerd v1.5.0-beta.3; https://github.com/containerd/containerd/blob/v1.5.0-beta.3/go.mod#L45C2-L45C77
It's 12 commits ahead of runtime-spec v1.0.2; opencontainers/runtime-spec@v1.0.2...e6143ca
We could consider using a tagged release here 🤔
There was a problem hiding this comment.
nod to using tagged if possible
|
Yes, I definitely think we should consider doing this; it reduces dependency hell if this dependency is somewhere in the tree (and is responsible for the circular dependency). At least I don't think it hurts to have it. I would still love to see a tagged version for the runtime-spec dependency in it as well (#58 (comment)), but that's slightly more tricky as we'd either downgrade to v1.0.2 (perhaps that's fine as minimum version); or upgrade to v1.1.0, but that's a larger change; opencontainers/runtime-spec@e6143ca...v1.1.0 |
client.go
Outdated
| Pid() uint32 | ||
| } | ||
|
|
||
| // Task is ta subset of containerd's Task interface. |
There was a problem hiding this comment.
| // Task is ta subset of containerd's Task interface. | |
| // Task is a subset of containerd's Task interface. |
go.mod
Outdated
| @@ -3,14 +3,6 @@ module github.com/containerd/nri | |||
| go 1.14 | |||
|
|
|||
| require ( | |||
| // when updating containerd, adjust the replace rules accordingly | |||
| github.com/containerd/containerd v1.5.0-beta.3 | |||
| github.com/opencontainers/runtime-spec v1.0.3-0.20200929063507-e6143ca7d51d | |||
There was a problem hiding this comment.
nod to using tagged if possible
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit da8a7e5) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit ae7840b) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
0.1_backport_remove_containerd_dependency
branch
from
9c23d8e
to
4275101
Compare
|
fixed the typo (backported #61), and I downgraded the minimum required version of runtime-spec to v1.0.2 (latest tagged version before v1.1.0). containerd 1.6 already depends on a more recent version of the runtime-spec (but uses a non-tagged version). @mikebrow @samuelkarp PTAL |
|
If this is merged, we can consider tagging a v0.1.1, and I will update my PR in containerd; containerd/containerd#9107 |
(cherry picked from commit da8a7e5)