Add support for propagating OpenTelemetry trace span information over NRI ttrpc connection. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a WithOpenTelemetry() option which turns on OpenTelemetry tracing instrumentation for called and served ttrpc requests in plugins/the stub. Signed-off-by: Krisztian Litkey <[email protected]>
Add a WithOpenTelemetry() option which turns on OpenTelemetry tracing instrumentation for called and served ttrpc requests in the runtime/adaptation. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 64.50% 64.11% -0.40%
==========================================
Files 9 9
Lines 1834 1853 +19
==========================================
+ Hits 1183 1188 +5
- Misses 500 512 +12
- Partials 151 153 +2 ☔ View full report in Codecov by Sentry. |
|
Closing in favor of #67. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set implements extra runtime/adaptation and plugin/stub NRI options which enable the propagation of OpenTelemetry trace span information over ttrpc connections.
This PR is an alternative to #67. This PR introduces two boolean options which tell NRI whether it internally should set up the necessary ttrpc options to enable otel trace span propagation over ttrpc. This brings in an indirect dependency on [github.com/containerd/]otelttrpc and OpenTelemetry itself.
#67 on the other hand simply opens up the ttrpc client and server used by NRI for extra ttrpc options. This allows one to pass in the necessary options to enable otel trace span propagation (essentially using the same otelttrpc instrumenting ttrpc interceptors as used here), both in NRI enabled runtimes and NRI plugins.
I wanted to ask feedback about which of these alternative approaches others find more preferable, hence I filed both as draft PRs.