Skip to content

Commit

Permalink
revert the alert-threshold to %130
Browse files Browse the repository at this point in the history
Signed-off-by: jiaxiao zhou <[email protected]>
  • Loading branch information
Mossaka committed Jun 13, 2024
1 parent cae1e42 commit bae8997
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions .github/workflows/benchmarks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ on:
schedule:
- cron: '0 0 * * *' # Runs daily at midnight
pull_request:

permissions:
contents: write # Required for commit comment for alert
pull-requests: write # Required for commit comment for alert

jobs:
benchmark:
Expand Down Expand Up @@ -40,10 +36,11 @@ jobs:
name: Criterion.rs Benchmark
tool: 'cargo'
output-file-path: output.txt
# GitHub API token to make a commit comment
github-token: ${{ secrets.GITHUB_TOKEN }}
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '1%'
# my experimental local benchmarking seems to have a 20% margin of error.
# So I set the alert threshold to 130% of the previous benchmark result.
# If the current benchmark result is more than 130% of the previous benchmark result, it will fail.
alert-threshold: '130%'
fail-on-alert: true
alert-comment-cc-users: '@runwasi-committers'
# Enable Job Summary
Expand Down

0 comments on commit bae8997

Please sign in to comment.