-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change bluechi controller port to 8420 #646
Conversation
Signed-off-by: pengshanyu <[email protected]>
qm-tier-0 test failed because Do you think it is better to modify |
I do not understand the issue, And with your change ci is failing on connectivity Can you please explain the cause of failure? where ids it happen and why? Is suspect the issue is the ip address and not the port |
Bluechi developers suggest that it would be better to use some port >1024, e.g. 8420, because 842 is a privileged port. |
Signed-off-by: pengshanyu <[email protected]>
Please refer this from here https://autosd.sig.centos.org/AutoSD-9/nightly/sample-images/ I would change it here, after port is changed in image manifest setup script is emulation osbuild qm manifest. @dougsland you thoughts are welcome |
controller_host_ip=$(hostname -I | awk '{print $1}') | ||
qm_bluechi_agent_config_file="/etc/qm/bluechi/agent.conf.d/agent.conf" | ||
if [[ -f "${qm_bluechi_agent_config_file}" ]]; then | ||
if ! grep "ControllerHost=${controller_host_ip}" "${qm_bluechi_agent_config_file}" >/dev/null; then | ||
sed -i '$a \ControllerHost='"${controller_host_ip}"'' ${qm_bluechi_agent_config_file} | ||
sed -i '$a \ControllerPort=8420' ${qm_bluechi_agent_config_file} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is better to move ControllerPort=8420
to bluechiSetup()
of setup
Once the port is changed in the qa image, we will support this change. |
842 is a privileged port of bluechi, so change it to 8420
Solved: #629