Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change bluechi controller port to 8420 #646

Closed

Conversation

pengshanyu
Copy link
Collaborator

842 is a privileged port of bluechi, so change it to 8420
Solved: #629

@pengshanyu
Copy link
Collaborator Author

pengshanyu commented Oct 31, 2024

qm-tier-0 test failed because qm.localrootfs is not connected
To solve this issue, we need to insert ControllerPort=8420 to /etc/qm/bluechi/agent.conf.d/agent.conf
But I noticed that /etc/qm/bluechi/agent.conf.d/agent.conf is generated by the bluechiSetup() function in setup

Do you think it is better to modify setup or insert ControllerPort=8420 into /etc/qm/bluechi/agent.conf.d/agent.conf after agent.conf is generated?
Hi @dougsland @Yarboa, could you help to take a look? Thanks.

@Yarboa
Copy link
Collaborator

Yarboa commented Oct 31, 2024

I do not understand the issue,
https://github.com/eclipse-bluechi/bluechi/blob/main/doc/man/bluechi-controller.conf.5.md
Port was not changed, so why there is a need to change it?

And with your change ci is failing on connectivity
https://artifacts.dev.testing-farm.io/ec019034-09be-4389-aaad-a8951424bb7e/

Can you please explain the cause of failure? where ids it happen and why?

Is suspect the issue is the ip address and not the port

@pengshanyu
Copy link
Collaborator Author

pengshanyu commented Oct 31, 2024

Bluechi developers suggest that it would be better to use some port >1024, e.g. 8420, because 842 is a privileged port.
The CI failure is because I changed the port to 8420 in ffi-tools, so we need to add ControllerPort=8420 into /etc/qm/bluechi/agent.conf.d/agent.conf accordingly

Signed-off-by: pengshanyu <[email protected]>
@Yarboa
Copy link
Collaborator

Yarboa commented Oct 31, 2024

Bluechi developers suggest that it would be better to use some port >1024, e.g. 8420, because 842 is a privileged port. The CI failure is because I changed the port to 8420 in ffi-tools, so we need to add ControllerPort=8420 into /etc/qm/bluechi/agent.conf.d/agent.conf accordingly

Please refer this from here
[root@localhost ~]# cat /etc/bluechi/controller.conf
[bluechi-controller]
AllowedNodeNames=host,qm.host

https://autosd.sig.centos.org/AutoSD-9/nightly/sample-images/
use qa image,

I would change it here, after port is changed in image manifest
To avoid deviations

setup script is emulation osbuild qm manifest.

@dougsland you thoughts are welcome

controller_host_ip=$(hostname -I | awk '{print $1}')
qm_bluechi_agent_config_file="/etc/qm/bluechi/agent.conf.d/agent.conf"
if [[ -f "${qm_bluechi_agent_config_file}" ]]; then
if ! grep "ControllerHost=${controller_host_ip}" "${qm_bluechi_agent_config_file}" >/dev/null; then
sed -i '$a \ControllerHost='"${controller_host_ip}"'' ${qm_bluechi_agent_config_file}
sed -i '$a \ControllerPort=8420' ${qm_bluechi_agent_config_file}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it is better to move ControllerPort=8420 to bluechiSetup() of setup

@pengshanyu
Copy link
Collaborator Author

Once the port is changed in the qa image, we will support this change.

@pengshanyu pengshanyu closed this Oct 31, 2024
@pengshanyu pengshanyu deleted the agent-flood-change-port branch October 31, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants