Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong deprecations #18

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

zonky2
Copy link
Contributor

@zonky2 zonky2 commented Nov 6, 2024

we have erroneously deprecated IMAGE_GET_HTML - but CONTROLLER_ADD_IMAGE_TO_TEMPLATE is deprecated

@zonky2 zonky2 requested a review from discordier November 6, 2024 12:43
@zonky2 zonky2 self-assigned this Nov 6, 2024
@zonky2 zonky2 added the bug label Nov 6, 2024
@zonky2 zonky2 added this to the 4.13.4 milestone Nov 6, 2024
we have erroneously deprecated IMAGE_GET_HTML - but CONTROLLER_ADD_IMAGE_TO_TEMPLATE is deprecated
@zonky2 zonky2 force-pushed the hotfix/fix_wrong_deprecations branch from 538b3c8 to a91ccde Compare November 6, 2024 12:48
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanheimes stefanheimes merged commit 57fd3f4 into support/4.13.0 Nov 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants