-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReplaceDataContainerValueRector
#8
base: main
Are you sure you want to change the base?
Conversation
hmmm… wouldn't this change that string everywhere? Like in templates and thelike? |
It would 🤔 This may need to be changed to an own rector that checks for array and/or entry types with the key being |
Been a while @aschempp The newest changes check if it's within an array with the key |
Table
to DC_Table::class
DataContainerConfigOptionToParameterRector
DataContainerConfigOptionToParameterRector
ReplaceDataContainerRector
ReplaceDataContainerRector
ReplaceDataContainerValueRector
As discussed with @aschempp, this shouldn't be specific and become a general DCA Rewriter that checks the array keys of TL_DCA and then handle the logic based on the passed arguments. |
Is there any update here? This would be a great help |
@rorych it's more complex than you would think and took quite some time, this branch is out of date already since it's become a NestedArrayItemValueRector that actually replaces a lot but it's not quite finished yet. Please mind that it's not even yet at the level to be used in production since it would only replace once but would actually have to replace multiple times in an array / DCA and is just seen as a PoC till all tests and examples would work with it. Once I change my focus back to contao-rector, I may wake that up again but for now I'm busy with other stuff. |
Description
Implements #6
Old:
New: