-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/image sizes #534
Feature/image sizes #534
Conversation
rabauss
commented
Aug 13, 2020
- Add notice tip for image size using from config file
- Update image size formats example analogous to the options in the backend
png: [webp, png] | ||
jpg: [webp, jpg] | ||
jpeg: [webp, jpeg] | ||
gif: [webp, gif] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably be reverted in the future, as this part of the documentation is just the output from config:dump-reference
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where can/should we add this as example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directly in the configuration of the contao/core-bundle
. However, within the documentation it would make sense to describe this part separately. imho we should introduce a new article called "Manage image sizes" in https://docs.contao.org/manual/en/layout/theme-manager/, explain the image sizes options of the back end there and then also mention the possibility to configure image sizes in the config.yml
directly, plus the examples.
A lot of work for sure, but having that would be worth it :) » #551
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly with links to (or text excerpts from):
@rabauss in the mean time I have added more info to the image processing article. I think this PR can be closed for now :) |