Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/image sizes #534

Closed
wants to merge 4 commits into from
Closed

Feature/image sizes #534

wants to merge 4 commits into from

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Aug 13, 2020

  • Add notice tip for image size using from config file
  • Update image size formats example analogous to the options in the backend

png: [webp, png]
jpg: [webp, jpg]
jpeg: [webp, jpeg]
gif: [webp, gif]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably be reverted in the future, as this part of the documentation is just the output from config:dump-reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can/should we add this as example?

Copy link
Contributor

@fritzmg fritzmg Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directly in the configuration of the contao/core-bundle. However, within the documentation it would make sense to describe this part separately. imho we should introduce a new article called "Manage image sizes" in https://docs.contao.org/manual/en/layout/theme-manager/, explain the image sizes options of the back end there and then also mention the possibility to configure image sizes in the config.yml directly, plus the examples.

A lot of work for sure, but having that would be worth it :) » #551

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from master to main January 22, 2021 12:03
@fritzmg
Copy link
Contributor

fritzmg commented Jun 3, 2021

@rabauss in the mean time I have added more info to the image processing article. I think this PR can be closed for now :)

@fritzmg fritzmg closed this Jun 3, 2021
@rabauss rabauss deleted the feature/image-sizes branch April 17, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants